Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.supervisor: fix tests #70073

Merged
merged 1 commit into from Sep 30, 2019
Merged

pythonPackages.supervisor: fix tests #70073

merged 1 commit into from Sep 30, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 30, 2019 •
edited

Motivation for this change

was able to build the package fine at home, but was brought up on #70019 and in hydra that it has some issues. Was able to reproduce the issue at work, and it seems using pytest as the test runner fixes the issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Taneb (brought up build issue originally)

[2 built, 1 copied (0.2 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70073
2 package were build:
python27Packages.supervisor python37Packages.supervisor

@ofborg ofborg bot requested a review from zimbatm September 30, 2019 17:40
@Taneb
Copy link
Contributor

Taneb commented Sep 30, 2019

This seems to have fixed it for me!

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.supervisor python37Packages.supervisor

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.supervisor python37Packages.supervisor

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.supervisor python37Packages.supervisor

@jonringer
Copy link
Contributor Author

build fixed with ofborg, no regression in nix-review

https://github.com/NixOS/nixpkgs/pull/70073
2 package were build:
python27Packages.supervisor python37Packages.supervisor

@jonringer jonringer merged commit 7587776 into NixOS:master Sep 30, 2019
@jonringer jonringer deleted the fix-supervisor branch September 30, 2019 20:47
@jonringer jonringer mentioned this pull request Oct 7, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @Taneb