Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manuals' links #117

Merged
merged 2 commits into from Oct 17, 2019
Merged

Update manuals' links #117

merged 2 commits into from Oct 17, 2019

Conversation

tssm
Copy link
Contributor

@tssm tssm commented Sep 30, 2019

No description provided.

Copy link

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current link appears to point to nothing, LGTM

@tssm
Copy link
Contributor Author

tssm commented Oct 1, 2019

I found a similar error in pill 8. If you agree I can check all the pills and update the PR

@jonringer
Copy link

I don't deal much with documentation, but fixing URLs seems like something that could be compiled into a single URL.

@tssm tssm changed the title Fix inherit URL in pill 7 Update manuals' links Oct 8, 2019
@tssm
Copy link
Contributor Author

tssm commented Oct 8, 2019

OK, I update all the links that point to any of the official manuals

@jonringer
Copy link

LGTM

cc @ryantm @grahamc (documentation)

Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though these links are broken, this PR overall makes the links better and doesn't break any links that were working so I'm going to merge it.

@@ -235,7 +235,7 @@

<para>
To do so, use
<link xlink:href="http://nixos.org/nix/manual/#idm47361539166560">recursive attribute sets</link>:
<link xlink:href="https://nixos.org/nix/manual/#idm140737322044432">recursive attribute sets</link>:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<link xlink:href="https://nixos.org/nix/manual/#idm140737322044432">recursive attribute sets</link>:
<link xlink:href="https://nixos.org/nix/manual/#idm140737322051184">recursive attribute sets</link>:

It seems like these idm anchors are not stable. This one is broken again.

@@ -303,7 +303,7 @@
</para>
<para>
Then we meet the
<link xlink:href="https://nixos.org/nix/manual/#idm140737318075200"><code>inherit</code> keyword</link>.
<link xlink:href="https://nixos.org/nix/manual/#idm140737322036688"><code>inherit</code> keyword</link>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is broken again too.

@@ -212,7 +212,7 @@

<para>
The
<link xlink:href="http://nixos.org/nix/manual/#idm47361539098656">// operator</link>
<link xlink:href="https://nixos.org/nix/manual/#idm140737322063856">// operator</link>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@ryantm ryantm merged commit f2f16ce into NixOS:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants