Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diceware: add missing 'setuptools' to propagatedBuildInputs #70158

Merged
merged 1 commit into from Oct 1, 2019
Merged

diceware: add missing 'setuptools' to propagatedBuildInputs #70158

merged 1 commit into from Oct 1, 2019

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Oct 1, 2019

Motivation for this change

As a side-effect of f7e28bf, the build no longer propagated 'setuptools', which
is a run-time dependency. See #68314 for further details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut

@teto
Copy link
Member

teto commented Oct 1, 2019

@GrahamcOfBorg build diceware

@ofborg ofborg bot requested a review from asymmetric October 1, 2019 07:45
@teto teto merged commit f641fca into NixOS:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asymmetric asymmetric Awaiting requested review from asymmetric

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@1000101 @teto