Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.drop-down-terminal: init at v24 #70042

Merged
merged 1 commit into from
Oct 2, 2019
Merged

gnomeExtensions.drop-down-terminal: init at v24 #70042

merged 1 commit into from
Oct 2, 2019
+73 −0

Conversation

ericdallo
Copy link
Member

Motivation for this change

Add the drop down terminal GNOME shell extension.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ericdallo ericdallo mentioned this pull request Sep 30, 2019
Closed
10 tasks
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 30, 2019
hedning
hedning approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ericdallo
Copy link
Member Author

ericdallo commented Oct 2, 2019 •
edited
Loading

Should I need to create a card in gnome3 github project?

@worldofpeace worldofpeace force-pushed the add-gnome-extension-drop-down-terminal branch from cd8d4dc to b1bf22a Compare October 2, 2019 13:47
@worldofpeace worldofpeace merged commit 643b6a8 into NixOS:master Oct 2, 2019
@ericdallo ericdallo deleted the add-gnome-extension-drop-down-terminal branch March 15, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
GNOME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericdallo @hedning @worldofpeace