Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.drop-down-terminal: init at v24 #70042

Merged

Conversation

ericdallo
Copy link
Member

Motivation for this change

Add the drop down terminal GNOME shell extension.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ericdallo
Copy link
Member Author

ericdallo commented Oct 2, 2019

Should I need to create a card in gnome3 github project?

@worldofpeace worldofpeace added this to Ready in GNOME Oct 2, 2019
@worldofpeace worldofpeace force-pushed the add-gnome-extension-drop-down-terminal branch from cd8d4dc to b1bf22a Compare October 2, 2019 13:47
@worldofpeace worldofpeace merged commit 643b6a8 into NixOS:master Oct 2, 2019
GNOME automation moved this from Ready to Done Oct 2, 2019
@ericdallo ericdallo deleted the add-gnome-extension-drop-down-terminal branch March 15, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
GNOME
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants