New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
djvulibre: add {lib, man} outputs #70040
base: staging
Are you sure you want to change the base?
Conversation
@peterhoeg I am sorry, I may had a strong wording and stupid position before *this. I still have old Nix models in my head sometimes. Creating a Since you were interested, maybe you would have other suggestions for package. |
Sorry about the late reply, but I've had very little time for these last few weeks. Regd the multiple outputs, I believe it's considered best practise to have the |
@peterhoeg I messaged above personally to you in the thread, because I needed to apologize. Regarding outputs, I can say that I know no such thing as you say, my experience so far is the contrary. I can inform you of this: The manual states only this about
The only thing that really mentioned is that The main and the only example that documentation gives for outs in split derivation is:
, which goes with the docs statement and not coincide with your consideration. This all can be read in docs, at the start of the https://nixos.org/nixpkgs/manual/#sec-multiple-outputs- section. So all things and my current experience point to that P.S. If you have experience of the contrary is true, and would request for me to do this, and you know this as best practice and have such experience - I would kindly inquiry you back, as a person with such experience, to check availability of such best practice recommendations you know in the documentation and add such information into the documentation of Nixpkgs, because that would be the most practical and would save time for everyone. As it would be good if we all would be able to rely on the documentation. Maybe as in the previous case, when I was thinking about the old Nix, maybe now here we have you remembering the old experience. I am behaving here as a good contributor. You probably already seen such cases in Nixpkgs. Also please remember that to the words of maintainer the contributor can not fight back, even to the statements of maintainer that are So far as I checked the |
dc5c626
to
2c4cf9f
Compare
2c4cf9f
to
2e5c32c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and runs fine for me when rebased on latest master. Tested a few executables from result-bin/bin/
and most of them have passed the --help
test.
cc @FRidh who merges stuff into staging a bunch and probably knows about multiple outputs. |
@Anton-Latukha is correct that there is no such practice of putting Though, it is somewhat uncommon to have all of nixpkgs/pkgs/os-specific/linux/firmware/fwupd/default.nix Lines 103 to 106 in e0f4ee7
|
This comment was marked as off-topic.
This comment was marked as off-topic.
I marked this as stale due to inactivity. → More info |
Motivation for this change
Split-package a
lib
andman
.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)