Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

berglas: init at 0.2.0 #70045

Merged
merged 1 commit into from Sep 30, 2019
Merged

berglas: init at 0.2.0 #70045

merged 1 commit into from Sep 30, 2019

Conversation

nagisa
Copy link
Contributor

@nagisa nagisa commented Sep 30, 2019

Motivation for this change

Berglas is a tool that is going to be desirable to some of the people working with google cloud services.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

r? @andir

@ofborg ofborg bot requested a review from kalbasit September 30, 2019 02:33
@andir andir self-assigned this Sep 30, 2019
andir
andir reviewed Sep 30, 2019
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -15475,11 +15477,11 @@ in
bridge-utils = callPackage ../os-specific/linux/bridge-utils { };

busybox = callPackage ../os-specific/linux/busybox { };
busybox-sandbox-shell = callPackage ../os-specific/linux/busybox/sandbox-shell.nix {
busybox-sandbox-shell = callPackage ../os-specific/linux/busybox/sandbox-shell.nix {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind splitting the whitespace changes out into a second commit? It is just in case people (in the future) might be confused why a new package touched busybox. It might save someone 15min of time wasted due to confusion.

andir
andir requested changes Sep 30, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then the whitespace issues this looks fine to me.

I managed to bootstrap a new berglas managed GCS bucket + KMS keys and create/update/read/delete those keys. 👍

@nagisa
Copy link
Contributor Author

nagisa commented Sep 30, 2019

Removed busybox whitespace portion of the diff.

@andir
Copy link
Member

andir commented Sep 30, 2019

@GrahamcOfBorg build berglas

@andir andir merged commit 475e88a into NixOS:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees

@andir andir

Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nagisa @andir