Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catfish: 1.4.7 -> 1.4.10 #70197

Merged
merged 1 commit into from Oct 2, 2019
Merged

catfish: 1.4.7 -> 1.4.10 #70197

merged 1 commit into from Oct 2, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Oct 1, 2019

Motivation for this change
  • Update to version 1.4.10
  • Add a new dependence on python-dbus
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo changed the title catfish: 1.4.7 -> 1.4.10 [WIP] catfish: 1.4.7 -> 1.4.10 Oct 1, 2019
@romildo romildo requested a review from jtojnar October 1, 2019 22:06
@romildo
Copy link
Contributor Author

romildo commented Oct 1, 2019

@GrahamcOfBorg build catfish

Lassulus
Lassulus approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, started it, searched for something and I am a little bit confused why someone would use this instead of find ;)

@Lassulus Lassulus merged commit 9f58b7c into NixOS:master Oct 2, 2019
@romildo romildo deleted the upd.catfish branch October 2, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @Lassulus