Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka: Remove old versions #70207

Closed
wants to merge 1 commit into from
Closed

kafka: Remove old versions #70207

wants to merge 1 commit into from
+1 −29

Conversation

NeQuissimus
Copy link
Member

Keeping latest two + latest 0.x and latest 1.x

Removed 0.9, 0.10, 1.0, 2.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 1, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 15, 2019 •
edited
Loading

From upstream:

What Is Our EOL Policy?

Given 3 releases a year and the fact that no one upgrades three times a year, we propose making sure (by testing!) that rolling upgrade can be done from each release in the past year (i.e. last 3 releases) to the latest version.

We will also attempt, as a community to do bugfix releases as needed for the last 3 releases.

Given the release dates of all these old versions, they should indeed be EOL.

@NeQuissimus maybe it needs a mention in 20.03 release note with a link to upstream documentation regarding upgrades ?
http://kafka.apache.org/23/documentation.html#upgrade

@c0bw3b c0bw3b added this to the 20.03 milestone Nov 19, 2019
@FRidh
Copy link
Member

FRidh commented Feb 10, 2020

this needs a rebase

@NeQuissimus
kafka: Remove old versions

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tonistiigi Tõnis Tiigi
GPG key ID: AFA9DE5F8AB7AF39
Expired
Verified
Learn about vigilant mode
b18d19c 
Keeping latest two + latest 0.x and latest 1.x

Removed 0.9, 0.10, 1.0, 2.0
@NeQuissimus
Copy link
Member Author

This should probably be merged into 20.03.

@petersjt014
Copy link
Member

Is this ready to merge?

Mic92
Mic92 reviewed Apr 27, 2020
View reviewed changes
pkgs/top-level/all-packages.nix
apacheKafka_1_1 = callPackage ../servers/apache-kafka { majorVersion = "1.1"; };
apacheKafka_2_0 = callPackage ../servers/apache-kafka { majorVersion = "2.0"; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be added to pkgs/top-level/aliases.nix

@DianaOlympos DianaOlympos mentioned this pull request Jun 20, 2020
Merged
5 tasks
@DianaOlympos
Copy link
Contributor

What would be needed to merge this ? If it is the alias thing, i can do. Same if this need a note in the changelog ? Let try to merge this for everyone sanity

@Mic92
Copy link
Member

Mic92 commented Jun 24, 2020

What would be needed to merge this ? If it is the alias thing, i can do. Same if this need a note in the changelog ? Let try to merge this for everyone sanity

If you want to take this PR over. Just do something like here: https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/aliases.nix#L705

@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@NeQuissimus
Copy link
Member Author

I am closing this as it is very stale. Somebody interested in removing old Kafka versions is welcome to submit a new PR.

@NeQuissimus NeQuissimus closed this Feb 3, 2021
@NeQuissimus NeQuissimus deleted the kafka_cleanup branch February 3, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@NeQuissimus @c0bw3b @FRidh @petersjt014 @DianaOlympos @Mic92 @ryantm