haskellPackages: fix barbly #70222
Merged
haskellPackages: fix barbly #70222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how to test this locally (I need to regenerate everything?). |
|
This is how I did test it, simple overlay and manually applying what I think the result of this PR will do. |
cdepillabout
reviewed
Oct 2, 2019
|
I've confirmed that @luke-clifton Thanks! |
|
@luke-clifton Sorry if you already know this, but in order to test this locally you can just build with $ nix-build /some/path/to/nixpkgs/with/this/PR/checked/out/ -A haskellPackages.barbly --arg config '{allowBroken=true;}'
...
/nix/store/wbxvpgkzmqqcavy96cvmh673b0pag2yf-barbly-0.1.0.0 |
peti
force-pushed
the
haskell-updates
branch
2 times, most recently
from
6501e2b
to
83ba157
Compare
Co-Authored-By: Dennis Gosnell <cdep.illabout@gmail.com>
|
Thanks @cdepillabout for pointing out that copy-paste error. |
|
@peti I've tested that this PR works on MacOSX. This PR should be ready to be merged. |
peti
requested changes
Oct 7, 2019
peti
force-pushed
the
haskell-updates
branch
2 times, most recently
from
5d075ab
to
56e1ea3
Compare
peti
pushed a commit
that referenced
this pull request
Oct 10, 2019
* haskellPackages: fix barbly Co-Authored-By: Dennis Gosnell <cdep.illabout@gmail.com>
peti
pushed a commit
that referenced
this pull request
Oct 13, 2019
* haskellPackages: fix barbly Co-Authored-By: Dennis Gosnell <cdep.illabout@gmail.com>
peti
pushed a commit
that referenced
this pull request
Oct 13, 2019
* haskellPackages: fix barbly Co-Authored-By: Dennis Gosnell <cdep.illabout@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @