Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.trackpy: disable plot tests #70223

Merged
merged 1 commit into from Oct 3, 2019
Merged

pythonPackages.trackpy: disable plot tests #70223

merged 1 commit into from Oct 3, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 2, 2019 •
edited

Motivation for this change

currently broken on master. Couldn't figure out a way to make the test pass, so i just disabled it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

https://github.com/NixOS/nixpkgs/pull/70223
3 package were build:
python27Packages.trackpy python37Packages.starfish python37Packages.trackpy

@jonringer jonringer requested a review from FRidh as a code owner October 2, 2019 05:25
@ofborg ofborg bot requested a review from costrouc October 2, 2019 05:38
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.trackpy python37Packages.starfish python37Packages.trackpy

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 3, 2019
@jonringer
Copy link
Contributor Author

this fixes 3 broken builds, merging

@jonringer jonringer merged commit 64205fa into NixOS:master Oct 3, 2019
@jonringer jonringer deleted the trackpy-disable-plot-tests branch October 3, 2019 03:51
@jonringer jonringer added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 3, 2019
@jonringer
Copy link
Contributor Author

backported 810a568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer