Revert "nixos/desktop-managers/xterm: Disable by default" [19.09] #70185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
requested review from
alyssais,
basvandijk,
Ericson2314,
FRidh,
infinisil,
joachifm,
nbp,
peti,
thoughtpolice,
ttuegel,
WilliButz and
zimbatm
as code owners
peti
approved these changes
Oct 1, 2019
ofborg
bot
added
6.topic: emacs
6.topic: erlang
6.topic: GNOME
ofborg
bot
added
8.has: module (update)
2.status: merge conflict
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
6.topic: TeX
sballert
added a commit
to sballert/nixos-config
that referenced
this pull request
Dec 30, 2019
A new nixos commit disables the desktop manager xterm by default, but my current setup needs it. See - nix-community/home-manager#862 - NixOS/nixpkgs#70185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f140dfb.
This reverts commit cf56cef.
This reverts commit 456c42c.
This has caused more issues than originally intended. It looks like many configurations rely on xterm being set to work correctly. This includes when you are starting a WM without going through a DE. We shouldn't break these setups (if stateVersion is unset). To make matters worse, most users don't actually know they are relying on xterm. LightDM seems to be the main one effected for now:
I expect more issues to come up as users of 19.03 upgrade to 19.09.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @