Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.vim-fsharp: init at 2018-11-13 #70186

Merged
merged 2 commits into from Oct 1, 2019
Merged

vimPlugins.vim-fsharp: init at 2018-11-13 #70186

merged 2 commits into from Oct 1, 2019

Conversation

kmein
Copy link
Member

@kmein kmein commented Oct 1, 2019 •
edited by jonringer

Motivation for this change

vim-fsharp was missing from vimPlugins

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
commits LGTM according to https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/vim.section.md#adding-new-plugins-to-nixpkgs

[61 built, 63 copied (852.0 MiB), 196.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70186
34 package were build:
vimPlugins.coc-git vimPlugins.coc-prettier vimPlugins.ctrlp-vim vimPlugins.defx-nvim vimPlugins.fastfold vimPlugins.jedi-vim vimPlugins.lh-vim-lib vimPlugins.nerdtree vimPlugins.semshi vimPlugins.tlib_vim vimPlugins.traces-vim vimPlugins.vim-addon-actions vimPlugins.vim-addon-completion vimPlugins.vim-addon-goto-thing-at-cursor vimPlugins.vim-addon-nix vimPlugins.vim-addon-sql vimPlugins.vim-addon-syntax-checker vimPlugins.vim-addon-toggle-buffer vimPlugins.vim-android vimPlugins.vim-commentary vimPlugins.vim-flutter vimPlugins.vim-fsharp vimPlugins.vim-fugitive vimPlugins.vim-gitgutter vimPlugins.vim-go vimPlugins.vim-grepper vimPlugins.vim-mucomplete vimPlugins.vim-plug vimPlugins.vim-signify vimPlugins.vim-snipmate vimPlugins.vim-snippets vimPlugins.vim-startify vimPlugins.vim-table-mode vimPlugins.vimtex

@jonringer jonringer merged commit 58899b8 into NixOS:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmein @jonringer