Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owncloud: fix qt wrapping #70187

Merged
merged 1 commit into from Oct 1, 2019
Merged

owncloud: fix qt wrapping #70187

merged 1 commit into from Oct 1, 2019

Conversation

tobiasBora
Copy link
Contributor

Motivation for this change

The QtWrap function changed recently according to #65399 and owncloud was not working anymore due to an error:

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-org.kde.kwin.qpa.

Aborted (core dumped)

Please, could you also push these change to nixos release 19.09?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @qknight

@ofborg ofborg bot requested a review from qknight October 1, 2019 16:30
@veprbl veprbl added 9.needs: port to stable A PR needs a backport to the stable release. 6.topic: qt/kde labels Oct 1, 2019
@veprbl
Copy link
Member

veprbl commented Oct 1, 2019

@GrahamcOfBorg build owncloud-client

@veprbl veprbl merged commit e120e00 into NixOS:master Oct 1, 2019
veprbl pushed a commit that referenced this pull request Oct 1, 2019
@tobiasBora @veprbl
owncloud-client: Use qt5's own mkDerivation (#70187)
9d4759d 
(cherry picked from commit e120e00)

cc #70187
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 1, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 2, 2019
@tobiasBora @dtzWill
owncloud-client: Use qt5's own mkDerivation (NixOS#70187)
a30bb97 
(cherry picked from commit e120e00)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qknight qknight Awaiting requested review from qknight

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobiasBora @veprbl