Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/cmt: Update error message for cmt #70166

Merged
merged 1 commit into from Oct 1, 2019
Merged

nixos/cmt: Update error message for cmt #70166

merged 1 commit into from Oct 1, 2019

Conversation

kcalvinalvin
Copy link
Member

Added clearer error message for the failed assertion with libinput

Motivation for this change

Fixes #69282

Things done

Changed the error message

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

@kcalvinalvin
nixos/cmt: Update error message for cmt
a96a5f3 
Added clearer error message for the failed assertion with libinput
@worldofpeace worldofpeace merged commit 4b7cac9 into NixOS:master Oct 1, 2019
@worldofpeace
Copy link
Contributor

Thanks for fixing that @kcalvinalvin, I will backport this to the latest release shortly.

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 2, 2019
@worldofpeace @dtzWill
Merge pull request NixOS#70166 from kcalvinalvin/plasma-cmt-fix
725b5aa 
nixos/cmt: Update error message for cmt

(cherry picked from commit 4b7cac9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabling both module cmt.nix and plasma5.nix throws a failed assertion and build aborts
2 participants
@kcalvinalvin @worldofpeace