rpc: add public Records as module ports. #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
suggested changes
Sep 30, 2019
nmigen/rpc.py
Outdated
| # considered a port. | ||
| for port_name, port in vars(elaboratable).items(): | ||
| if not port_name.startswith("_") and isinstance(port, (Signal, Record)): | ||
| def flatten(port): |
There was a problem hiding this comment.
I think you can use port._lhs_signals() here. (It's internal, but nmigen.rpc is a part of nMigen, so it's fine.)
We should maybe expose something like this as a public API for Record, but that would be a separate discussion.
Codecov Report
@@ Coverage Diff @@
## rpc #241 +/- ##
=======================================
Coverage 82.23% 82.23%
=======================================
Files 33 33
Lines 5495 5495
Branches 1174 1174
=======================================
Hits 4519 4519
Misses 842 842
Partials 134 134Continue to review full report at Codecov.
|
whitequark
approved these changes
Sep 30, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case: modules exposing streams or bus interfaces as ports.