Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qubes-core-vchan-xen: init at 4.1.2 #70204

Merged
merged 1 commit into from
Oct 2, 2019
Merged

qubes-core-vchan-xen: init at 4.1.2 #70204

merged 1 commit into from
Oct 2, 2019
+32 −0

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Oct 1, 2019

Motivation for this change

Adding core QubesOS services for better integration.

During CCCamp19 we (@erictapen, +others) sat down with @marmarek and talked about NixOS Integration in QubesOS.

This package is a dependency for qubes-core-qrexec.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@marmarek
Copy link

marmarek commented Oct 1, 2019

I haven't uploaded my WIP version yet (I've got half into qrexec packaging), but I did improved makefile in qubes-core-vchan-xen upstream. On camp we've hit various issues about library paths (pkgconfig file, include etc). Now it's possible to put them in /lib /include etc, instead of /usr, with a PREFIX=/.

@marmarek
Copy link

marmarek commented Oct 1, 2019

And thanks for pushing it here!

@0x4A6F 0x4A6F force-pushed the master-qubes-core-vchan-xen branch from 43a2d80 to 30a0d6e Compare October 1, 2019 21:13
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Oct 1, 2019
@0x4A6F 0x4A6F force-pushed the master-qubes-core-vchan-xen branch 2 times, most recently from 0261bbe to f54b5b6 Compare October 1, 2019 21:48
@Lassulus
Copy link
Member

Lassulus commented Oct 1, 2019

So this just seem to be some header files and nothing else? so not much to review then I guess

@marmarek
Copy link

marmarek commented Oct 1, 2019

There should be a library (.so) too.

@0x4A6F
Copy link
Member Author

0x4A6F commented Oct 1, 2019 

/nix/store/nwjvmbqp3ldzy9hhbcd363sldimhg3s3-qubes-core-vchan-xen-4.1.2
├── include
│   ├── u2mfn-kernel.h
│   ├── u2mfnlib.h
│   └── vchan-xen
│       └── libvchan.h
└── lib
    ├── libu2mfn.so
    ├── libvchan-xen.so
    └── pkgconfig
        └── vchan-xen.pc

4 directories, 6 files

@0x4A6F 0x4A6F force-pushed the master-qubes-core-vchan-xen branch from f54b5b6 to 61e6fab Compare October 2, 2019 15:23
@0x4A6F
qubes-core-vchan-xen: init at 4.1.2

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Mic92 Jörg Thalheim
GPG key ID: B3F5D81B0C6967C4
Expired
Verified
Learn about vigilant mode
ffa991e
@0x4A6F 0x4A6F changed the title qubes-core-vchan-xen: init at 4.1.0 qubes-core-vchan-xen: init at 4.1.2 Oct 2, 2019
@0x4A6F 0x4A6F force-pushed the master-qubes-core-vchan-xen branch from 61e6fab to ffa991e Compare October 2, 2019 15:27
Lassulus
Lassulus approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit dc00a98 into NixOS:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marmarek marmarek

@Lassulus Lassulus

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0x4A6F @marmarek @Lassulus