Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgmodeler: init at 0.9.1 #70203

Merged
merged 2 commits into from Oct 2, 2019
Merged

pgmodeler: init at 0.9.1 #70203

merged 2 commits into from Oct 2, 2019

Conversation

esclear
Copy link
Contributor

@esclear esclear commented Oct 1, 2019 •
edited

Motivation for this change

pgModeler (PostgreSQL Database Modeler) is an open source database modeling tool designed for PostgreSQL.
It is not packaged for NixOS yet, so I did that.

I'm a bit unsure about whether the complete postgresql package is needed as a dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
    (No dependencies)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    (+ 563.73 MB)
  • Ensured that relevant documentation is up to date
    (No relevant documentation)
  • Fits CONTRIBUTING.md.
Notify maintainers

That'd be me :)

@Lassulus
Copy link
Member

Lassulus commented Oct 1, 2019

can you change the commit message to maintainers: Add @esclear ?

@esclear
maintainers: Add @esclear
45a2072
@esclear
pgmodeler: init at 0.9.1
bed7146 
pgModeler (PostgreSQL Database Modeler) is an open source database modeling tool designed for PostgreSQL.
@esclear
Copy link
Contributor Author

esclear commented Oct 2, 2019

Sure thing.

Lassulus
Lassulus approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, opened a good looking graphical frontend where I was overwhelmed by the options I have to design tables and stuff

@Lassulus Lassulus merged commit 0cd4732 into NixOS:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@esclear @Lassulus