[19.09] linux: drop non-LTS versioned kernel attributes #70202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
reviewed
Oct 1, 2019
|
@NeQuissimus We've discussed this over on IRC, and there's only one question left to answer, and only you can answer it. Would dropping the named attributes for non-LTS kernel version cause issues with backporting from master to stable? We figured that it may cause the kernel introduction cherry-pick to conflict in all-packages.nix, nothing else though. This PR (and the release docs paragraph) about dropping versioned attribute names from stable releases currently hinges on that question alone. Thanks! |
|
No problem, the individual versions should still cherry-pick just fine (i.e. |
NeQuissimus
approved these changes
Oct 7, 2019
samueldr
approved these changes
Oct 7, 2019
Quoting the release manual: > Remove attributes that we know we will not be able to support, > especially if there is a stable alternative. E.g. Check that our Linux > kernels' projected end-of-life are after our release projected > end-of-life
|
🎉 |
|
Maybe it's worth including this and a suggested "fix" in the release notes. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting the release manual: