Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: add jonathanmarler #70060

Merged
merged 1 commit into from Sep 30, 2019
Merged

Conversation

marler8997
Copy link
Contributor

Motivation for this change

Add myself as a maintainer for the rund package which is in this PR: #59047

@Lassulus requested the maintainer addition be in a separate PR (#59047 (comment))

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Lassulus

@Lassulus
Copy link
Member

I actually meant separate commit in the same PR, but never mind :D

@Lassulus Lassulus merged commit 5afde25 into NixOS:master Sep 30, 2019
@marler8997 marler8997 deleted the addJonathanMarler branch October 1, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants