Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glibc: fix cross compilation #70218

Closed
wants to merge 1 commit into from
Closed

glibc: fix cross compilation #70218

wants to merge 1 commit into from

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Oct 2, 2019

At least to aarch64-multiplatform.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@veprbl veprbl added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Oct 2, 2019
@Mic92
Copy link
Member

Mic92 commented Oct 2, 2019

On which commit did this fix your build? nix-build -A pkgsCross.aarch64-multiplatform.glibc works fine for me on f349aa3

@eadwu
Copy link
Member Author

eadwu commented Oct 2, 2019

Was from a while ago, 96ac71d, but since it's fixed I'll close.

@eadwu eadwu closed this Oct 2, 2019
@eadwu eadwu deleted the glibc/fix-cross-compilation branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @Mic92 @veprbl