Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libatomic for 32-bit ARM #3114

Merged
merged 2 commits into from Oct 11, 2019
Merged

Conversation

matthewbauer
Copy link
Member

Fixes #3113

@matthewbauer
Copy link
Member Author

/cc @grahamc @edolstra

@edolstra
Copy link
Member

This is weird. Shouldn't this be something handled by gcc / libstdc++?

@matthewbauer
Copy link
Member Author

matthewbauer commented Oct 10, 2019

This is weird. Shouldn't this be something handled by gcc / libstdc++?

Yeah I would expect that to happen, but it doesn't look like it has. At least boost's atomic, which uses this symbol should have this check. Most platforms have hardware atomics, but arm32 does not so it needs to use the software version. It is probably necessary for PPC too.

Other projects like:

do this too.

/cc @lopsided98

@edolstra edolstra merged commit 7d8c99e into NixOS:master Oct 11, 2019
@puckipedia
Copy link
Contributor

Came across this issue while trying to package 2.3.10 Nix, and after backporting the commit, turns out, it never worked! $LIBS has not been looked at since Automake was removed in 2014, in commit 0c6d62c! Adding @LIBS@ to the LDFLAGS in the Makefile.config.in seems to have made it work, but feels a bit hacky (I don't entirely know what the interaction of the custom build system is with how autoconf does things by default..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARMv7 Build Failure: undefined reference to __atomic_fetch_add_8
3 participants