Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcachefs: 2019-10-01 #70217

Merged
merged 2 commits into from Oct 5, 2019
Merged

bcachefs: 2019-10-01 #70217

merged 2 commits into from Oct 5, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Oct 2, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@Chiiruno Chiiruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bcachefs (linux) commit seems to be broken.

fatal: reference is not a tree: 380885b0b8c38dc770c48602325de77171acc419
Unable to checkout 380885b0b8c38dc770c48602325de77171acc419 from https://evilpiepirate.org/git/bcachefs.git.
builder for '/nix/store/bhc7pfc4b08cscy241iyap6yfj30rgc1-bcachefs-380885b.drv' failed with exit code 1
cannot build derivation '/nix/store/f1bfl4ncywjh7wzk2b4ng2l3jxbblz1x-linux-5.2.2019.10.01.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pa50w8ida032lkz3154p7l9idffadc7g-nixos-system-machine-20.03.git.c18e6fb.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jyqid607yp72gjdd0iry307rqg66c8rk-nixos-vm.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/la7nbvy3iygs0yd22wq7887zh51znknm-nixos-test-driver-bcachefs.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/p01ajjgh2292mf4yq5hpdajm6w3jsrgq-vm-test-run-bcachefs.drv': 1 dependencies couldn't be built
error: build of '/nix/store/p01ajjgh2292mf4yq5hpdajm6w3jsrgq-vm-test-run-bcachefs.drv' failed

@Chiiruno
Copy link
Contributor

Chiiruno commented Oct 2, 2019

On a side note, thoughts on using https://github.com/koverstreet/bcachefs instead of his website?
Seems to be a mirror made by him.
also cute avatar

@eadwu
Copy link
Member Author

eadwu commented Oct 2, 2019

Looks like it got rebased, I suppose using the Github sources won't make a difference besides the time difference.

@eadwu
Copy link
Member Author

eadwu commented Oct 2, 2019

Fixed hash.

Copy link
Contributor

@Chiiruno Chiiruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as usual, LGTM.

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

not tested tho

@dywedir dywedir merged commit 2a116c3 into NixOS:master Oct 5, 2019
@eadwu eadwu deleted the bcachefs/update-8 branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants