Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: Speed up cross callHackage by using native source #70193

Closed
wants to merge 1 commit into from
Closed

haskell: Speed up cross callHackage by using native source #70193

wants to merge 1 commit into from

Conversation

Ericson2314
Copy link
Member

Motivation for this change

backport of #70192

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ericson2314
haskell: Speed up cross callHackage by using native source
d6f1e70 
The extract of code from hackage is the same on all platforms.
@Ericson2314 Ericson2314 changed the title haskell: Fix more cross voilations haskell: Speed up cross callHackage by using native source Oct 1, 2019
@matthewbauer
Copy link
Member

Backporting isn't necessary here

@matthewbauer matthewbauer reopened this Oct 1, 2019
@Ericson2314
Copy link
Member Author

Opps @matthewbauer was right and I mislead him.

@Ericson2314 Ericson2314 closed this Oct 1, 2019
@Ericson2314 Ericson2314 deleted the call-hackage-cross branch October 2, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @matthewbauer