Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt-einsum: fix build by disabling test. #68865

Closed
wants to merge 1 commit into from
Closed

opt-einsum: fix build by disabling test. #68865

wants to merge 1 commit into from

Conversation

teh
Copy link
Contributor

@teh teh commented Sep 15, 2019

Motivation for this change

zero hydra failures: #68361

It's not 100% clear to me why the stack traces contain <ExceptionInfo ValueError tblen=2> instead of the provided string but given that all other tests pass and the exceptions are being raised further up it's reasonably safe to disable this test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@teh teh requested a review from FRidh as a code owner September 15, 2019 21:08
@jonringer
Copy link
Contributor

superseded by #69967, sorry, didn't see your PR when I made mine

@jonringer jonringer closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teh @jonringer