Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackage.cli-helpers: disable python2 tests #68708

Merged
merged 1 commit into from Oct 2, 2019
Merged

pythonPackage.cli-helpers: disable python2 tests #68708

merged 1 commit into from Oct 2, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 13, 2019 •
edited

Motivation for this change

#68361

There's an import error with the backports namespace. I tried to even add the __path__ = pkg.extend(__path__,__name) hack to the affected backports packages, but it still didn't work (but worked using nix-shell). It was weird. Decided to just check on python3 since python2 is EOL in 3.5 months.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68708
1 package were build:
python27Packages.cli-helpers

@ofborg ofborg bot requested a review from kalbasit September 13, 2019 22:03
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.cli-helpers python3Packages.cli-helpers

@jonringer
Copy link
Contributor Author

it's been 2 weeks, did another nix-review still valid.

@jonringer jonringer merged commit 7eed92a into NixOS:master Oct 2, 2019
@jonringer jonringer deleted the disable-cli-helper-py2-tests branch October 2, 2019 05:48
@jonringer
Copy link
Contributor Author

backported as 15bc013

@jonringer jonringer added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @kalbasit