Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.chart-studio: init at 1.0.0 #68679

Closed
wants to merge 1 commit into from
Closed

pythonPackages.chart-studio: init at 1.0.0 #68679

wants to merge 1 commit into from
+27 −0

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 13, 2019 •
edited
Loading

Motivation for this change

the plotly package moved the plotly.plotly functionality into this package, eventually it will be needed by many packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[nix-shell:/home/jon/.cache/nix-review/pr-68679]$ nix path-info -Sh ./results/python*
/nix/store/4nh5xj9vv9wiwnlphhxcqwwyyk3y2km5-python3.7-chart-studio-1.0.0         180.1M
/nix/store/w2g9hv30v00l05qmw8hs8p42g218n6s7-python2.7-chart-studio-1.0.0         185.6M

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68679
2 package were build:
python27Packages.chart-studio python37Packages.chart-studio

Sorry, something went wrong.

@jonringer jonringer requested a review from FRidh as a code owner September 13, 2019 16:09
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 13, 2019
@risicle
Copy link
Contributor

risicle commented Sep 14, 2019

Builds for me, macos 10.13. But 🤷‍♂️ no tests.

@jonringer
Copy link
Contributor Author

closing in priority of #70220 seeing as it's included in that PR and fixes a build

@jonringer jonringer closed this Oct 2, 2019
@jonringer jonringer deleted the add-chart-studio branch October 2, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @risicle