Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-{web,desktop}: 1.4.0 -> 1.4.1 #70200

Merged
merged 2 commits into from Oct 1, 2019
Merged

riot-{web,desktop}: 1.4.0 -> 1.4.1 #70200

merged 2 commits into from Oct 1, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Oct 1, 2019

Motivation for this change

This PR updates Riot to the latest version.

They're making new releases annoyingly fast.
Is there a way to automate updates for this package through the package update bot?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/): could start the electron app and chat
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @bachp

@ofborg ofborg bot requested a review from worldofpeace October 1, 2019 19:09
@Ma27 Ma27 self-assigned this Oct 1, 2019
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 1, 2019
@Ma27
Copy link
Member

Ma27 commented Oct 1, 2019

Regarding automated updates: it's actually listed at repology (https://repology.org/project/riot/versions), not sure though why it's not done by the update bot (or you're just too fast 😄 )

@Ma27 Ma27 merged commit bb8b193 into NixOS:master Oct 1, 2019
@Ma27
Copy link
Member

Ma27 commented Oct 1, 2019

Thanks! Backported as e326c4f and 445ea37.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 1, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 2, 2019
@Ma27 @dtzWill
Merge pull request NixOS#70200 from pacien/riot-v1.4.1
52d68c7 
riot-{web,desktop}: 1.4.0 -> 1.4.1

(cherry picked from commit bb8b193)
@worldofpeace
Copy link
Contributor

Thanks @pacien @Ma27 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees

@Ma27 Ma27

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pacien @Ma27 @worldofpeace