Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

universal-ctags: Add jansson dependency #70199

Merged
merged 1 commit into from Oct 2, 2019
Merged

universal-ctags: Add jansson dependency #70199

merged 1 commit into from Oct 2, 2019

Conversation

tredontho
Copy link
Contributor

Motivation for this change

Add JSON support to universal-ctags. Resolves #70191

Things done

Added jansson dependency to the universal-ctags nixpkg

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mimame

@tredontho
universal-ctags: Add jansson dependency
f2eabd4 
Add jansson dependency to enable JSON support
@tredontho
Copy link
Contributor Author

I tried building with sandboxing, but it built and exited very quickly, so I'm not sure that I did it correctly. This is what I ran: nix-build --option sandbox true -A universal-ctags from the nixpkgs root directory. I was able to use the generated binary to generate a JSON tags file as desired. Please let me know what else I can do to get this merged.

@ofborg ofborg bot requested a review from mimame October 1, 2019 18:34
mimame
mimame approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@mimame mimame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the package with the patch using
nix-shell -p universal-ctag -I=/path/to/nixpkgs/repository/
and it's working fine

Thanks so much for your patch!

@marsam marsam merged commit a65eab2 into NixOS:master Oct 2, 2019
@marsam
Copy link
Contributor

marsam commented Oct 2, 2019

Thank you @tredontho and @mimame

@tredontho tredontho deleted the tredontho/universal-ctags-jansson branch October 7, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimame mimame mimame approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JSON Support to universal-ctags
4 participants
@tredontho @marsam @mimame @Janik-Haag