Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpegthumbnailer: 2.2.0 -> 2.2.1 #70201

Merged
merged 1 commit into from Oct 3, 2019
Merged

ffmpegthumbnailer: 2.2.0 -> 2.2.1 #70201

merged 1 commit into from Oct 3, 2019

Conversation

mtrsk
Copy link
Member

@mtrsk mtrsk commented Oct 1, 2019

Motivation for this change

Package update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from jagajaga October 1, 2019 19:15
@Ma27
Copy link
Member

Ma27 commented Oct 3, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit abbf89d into NixOS:master Oct 3, 2019
@mtrsk mtrsk deleted the update-ffmpegthumbnailer branch October 3, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mtrsk @Ma27