Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.git-extras: 4.7.0 -> 5.0.0 #70210

Merged
merged 1 commit into from Nov 12, 2019
Merged

gitAndTools.git-extras: 4.7.0 -> 5.0.0 #70210

merged 1 commit into from Nov 12, 2019

Conversation

cko
Copy link
Member

@cko cko commented Oct 1, 2019 •
edited

Motivation for this change

Update to latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from spwhitt October 1, 2019 22:07
@teto
Copy link
Member

teto commented Oct 2, 2019

changelog: https://github.com/tj/git-extras/releases/tag/5.0.0

@teto
Copy link
Member

teto commented Oct 2, 2019

https://github.com/tj/git-extras/blob/5.0.0/Installation.md doesn't list which as buildInput. they may need to fix it.

@cko
Copy link
Member Author

cko commented Oct 2, 2019

changelog: https://github.com/tj/git-extras/releases/tag/5.0.0

I don't get what you want to say with this comment. Should something be added to this PR?

@teto
Copy link
Member

teto commented Oct 3, 2019

when reviewing, it helps knowing what changed to know where the potential problems are (espcially when there is a big version jump), putting it helps the reviewers. I think it's a good idea to put it in the commit message as well. I do look at git log and I am sure others do as well.

@cko
Copy link
Member Author

cko commented Oct 3, 2019

I rewrote the commit message.

@teto
Copy link
Member

teto commented Oct 3, 2019

@GrahamcOfBorg build gitAndTools.git-extras

@teto
Copy link
Member

teto commented Oct 3, 2019

there seems to be some issues

@cko
Copy link
Member Author

cko commented Oct 4, 2019 •
edited

@teto fixed :-)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/79

@c0bw3b c0bw3b merged commit 9d0c1c1 into NixOS:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyball lilyball lilyball left review comments

@c0bw3b c0bw3b c0bw3b approved these changes

@spwhitt spwhitt Awaiting requested review from spwhitt

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cko @teto @nixos-discourse @lilyball @c0bw3b