Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protolock: init at 0.14.1 #70167

Merged
merged 1 commit into from
Oct 7, 2019
Merged

protolock: init at 0.14.1 #70167

merged 1 commit into from
Oct 7, 2019
+28 −0

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Oct 1, 2019 •
edited by jonringer
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@groodt
Copy link
Contributor Author

groodt commented Oct 1, 2019

@GrahamcOfBorg build protolock

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 1, 2019
@ofborg ofborg bot requested a review from kalbasit October 1, 2019 11:18
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 1, 2019
@groodt
Copy link
Contributor Author

groodt commented Oct 1, 2019

@GrahamcOfBorg build protolock

jonringer
jonringer approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (with @kalbasit comment)
executable seems to work

[5 built, 1 copied (43.0 MiB), 5.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70167
1 package were build:
protolock

$ nix path-info -Sh ./results/protolock
/nix/store/kqv5r3yz90sb87mmrylmz562861wbac2-protolock-0.14.1       8.3M

@jonringer
Copy link
Contributor

@GrahamcOfBorg build protolock

@ofborg ofborg bot requested a review from kalbasit October 1, 2019 22:44
@jonringer
Copy link
Contributor

should the plugin-sample and plugin-sample-error executables be there?

$ ls -a ./results/protolock/bin/
plugin-sample  plugin-sample-error  protolock

@jonringer
Copy link
Contributor

jonringer commented Oct 1, 2019 •
edited
Loading

if they should be removed, you can always do:

  # remove example sample executables
  postInstall = ''
    rm $out/bin/plugin*
  '';

$ ls -l ./result/bin/
.r-xr-xr-x 2.7M root 31 Dec  1969 protolock

@groodt
Copy link
Contributor Author

groodt commented Oct 2, 2019

should the plugin-sample and plugin-sample-error executables be there?

No, they probably aren't necessary. I'll remove them.

@jonringer
Copy link
Contributor

jonringer commented Oct 2, 2019 •
edited
Loading

wow, coming back to this, the line "example sample executable" seems a little redundant...

EDIT: In my head I had it as example "sample executables". Sorry :(

Should be fine as is, unless you want to change the comment. The code itself LGTM

@jonringer
Copy link
Contributor

@GrahamcOfBorg build protolock

jonringer
jonringer approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70167
1 package were build:
protolock

[nix-shell:/home/jon/.cache/nix-review/pr-70167]$ tree ./results/protolock
./results/protolock
└── bin
    └── protolock

1 directory, 1 file

@groodt
protolock: init at 0.14.1

Verified

This commit was signed with the committer’s verified signature.
MichaReiser Micha Reiser
SSH Key Fingerprint: ecGsN1ElBc6rDn4Ge3zV90y0fffKRH+1PNbJCxfpPEs
Verified
Learn about vigilant mode
3e8b296
@groodt
Copy link
Contributor Author

groodt commented Oct 2, 2019

Ready for review @kalbasit

@jonringer
Copy link
Contributor

If he doesn't respond in a day or two, I'll merge

@groodt
Copy link
Contributor Author

groodt commented Oct 7, 2019

Waiting for anything specific @jonringer @kalbasit ?

@jonringer
Copy link
Contributor

just got back from a weekend out-of-town, and wanted other maintainers some time to comment.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build protolock

@jonringer
Copy link
Contributor

builds on all platforms
runs fine on NixOS

@jonringer jonringer merged commit 3b40812 into NixOS:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@kalbasit kalbasit

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@groodt @jonringer @kalbasit