Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdf4: Disable some flaky tests #70080

Closed
wants to merge 1 commit into from
Closed

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This should reduce the nondeterministic build failures of hdf4.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@veprbl
Copy link
Member

veprbl commented Sep 30, 2019

Notice that you modify list of tests disabled on Darwin, but claim to fix failures on x86_64-linux.

cc #61059 @lopsided98

@lopsided98
Copy link
Contributor

Yeah, this PR should have no effect on Linux in its current form. We might want to try the suggestions in the other PR, such as limiting parallelism or disabling it altogether.

@knedlsepp
Copy link
Member Author

Oh. That was very unobservant from me. I didn't properly check that since I initially disabled these tests on all platforms the isDarwin check snuck in.
I'm a little wondering about #61059 however. While it states that it "fixes tests on some machines" in reality that particular commit only enabled some tests on linux.
I just became aware yesterday that somebody on discourse had trouble building gdal: https://discourse.nixos.org/t/problem-to-install-hdf5-gdal/4203
on 19.03 because of some flaky tests. I would prefer to disable these tests unconditionally on all platforms if they are flaky for whatever reason. What do you suggest in this case @veprbl?

@lopsided98
Copy link
Contributor

lopsided98 commented Sep 30, 2019

I don't really know why #61059 fixed the build on my test machines, but my suspicion is that that there are some missing dependency relationships in the Makefile, resulting in a race condition when parallel building is enabled. Enabling more tests changed the timing slightly, making things happen in the correct order. This is obviously not a reliable fix though.

@veprbl
Copy link
Member

veprbl commented Oct 6, 2019

If I understand correctly, merging this will break build on some of the machines listed in #61059 . Should this be investigated more thoroughly? Or maybe we just disable tests for now?

@knedlsepp
Copy link
Member Author

Yes, Maybe disabling the tests is the better option here.

@veprbl
Copy link
Member

veprbl commented Oct 6, 2019

By disabling tests I mean disabling all of them with doCheck = false.

@FRidh
Copy link
Member

FRidh commented Feb 10, 2020

Status?

@stale

This comment has been minimized.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 8, 2020
@knedlsepp knedlsepp closed this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants