New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hdf4: Disable some flaky tests #70080
Conversation
Notice that you modify list of tests disabled on Darwin, but claim to fix failures on x86_64-linux. |
Yeah, this PR should have no effect on Linux in its current form. We might want to try the suggestions in the other PR, such as limiting parallelism or disabling it altogether. |
Oh. That was very unobservant from me. I didn't properly check that since I initially disabled these tests on all platforms the isDarwin check snuck in. |
I don't really know why #61059 fixed the build on my test machines, but my suspicion is that that there are some missing dependency relationships in the Makefile, resulting in a race condition when parallel building is enabled. Enabling more tests changed the timing slightly, making things happen in the correct order. This is obviously not a reliable fix though. |
If I understand correctly, merging this will break build on some of the machines listed in #61059 . Should this be investigated more thoroughly? Or maybe we just disable tests for now? |
Yes, Maybe disabling the tests is the better option here. |
By disabling tests I mean disabling all of them with |
Status? |
Motivation for this change
This should reduce the nondeterministic build failures of hdf4.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @