Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitkraken: 6.2.0 -> 6.2.1 #70056

Merged
merged 1 commit into from Oct 2, 2019
Merged

gitkraken: 6.2.0 -> 6.2.1 #70056

merged 1 commit into from Oct 2, 2019

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Sep 30, 2019

Motivation for this change

https://support.gitkraken.com/release-notes/current/#version-621

Note

I was unable to test this on nixpkgs master due to a new version of rustc being available (needed by gtk which needs librsvg, which needs rust), which was trying to build from source...

I did test this from an overlay, though, and the open file dialog, pushing, pulling, profile creation process and settings management all seem to work fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @xNWDD

Copy link
Contributor

@ck3d ck3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully built and started gitkraken

Copy link
Member

@kmein kmein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with nix-review. Started git kraken and registered, looked at a repo (logs, diff).

@Lassulus Lassulus merged commit cdc963c into NixOS:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants