Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated gstreamer binaries for UWP. #24183

Merged
merged 1 commit into from Sep 12, 2019
Merged

Use updated gstreamer binaries for UWP. #24183

merged 1 commit into from Sep 12, 2019

Conversation

jdm
Copy link
Member

@jdm jdm commented Sep 11, 2019

This removes a bunch of WACK errors.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because no tests on windows

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 11, 2019
@ferjm
Copy link
Contributor

ferjm commented Sep 12, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 032faba has been approved by ferjm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 12, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 032faba with merge 2ff34e5...

bors-servo pushed a commit that referenced this pull request Sep 12, 2019
Use updated gstreamer binaries for UWP.

This removes a bunch of WACK errors.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because no tests on windows

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24183)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: ferjm
Pushing 2ff34e5 to master...

@bors-servo bors-servo merged commit 032faba into master Sep 12, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 12, 2019
@SimonSapin SimonSapin deleted the jdm-patch-53 branch September 30, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants