Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two css-grid tests that were broken by Ahem web font transition. #18997

Merged
merged 1 commit into from Sep 11, 2019

Conversation

LukeZielinski
Copy link
Contributor

These tests were broken because the checkLayout method implicitly calls done() itself, which causes only the first subtest to run.

But we can call checkLayout(.., callDone=false) and call done() ourselves instead.

Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hexcles Hexcles merged commit 86fb490 into web-platform-tests:master Sep 11, 2019
@LukeZielinski LukeZielinski deleted the fix-css-grid-ahem branch September 11, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants