Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cide: remove #68505

Merged
merged 1 commit into from Sep 12, 2019
Merged

cide: remove #68505

merged 1 commit into from Sep 12, 2019

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Sep 11, 2019

Motivation for this change

I am not longer maintaining this project and there are much better tools that exist now in the docker ecosystem. Look at buildah for example

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@zimbatm
Copy link
Member Author

zimbatm commented Sep 11, 2019

@nicknovitski are you still using this project?

@lheckemann lheckemann added this to the 19.09 milestone Sep 12, 2019
@zimbatm zimbatm merged commit ab03086 into NixOS:master Sep 12, 2019
@zimbatm zimbatm deleted the delete-cide branch September 12, 2019 20:02
zimbatm added a commit that referenced this pull request Sep 12, 2019
@zimbatm
cide: remove (#68505)
8d1e769 
(cherry picked from commit ab03086)
@zimbatm
Copy link
Member Author

zimbatm commented Sep 12, 2019

cherry-picked at 8d1e769 in 19.09

@nicknovitski
Copy link
Contributor

I'm not using it, no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zimbatm @nicknovitski @worldofpeace @lheckemann