Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prometheus rspamd exporter and test #68496

Merged
merged 2 commits into from Sep 11, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

This adds a module that configures the json exporter,
which then acts as an exporter for rspamd.

This means one only needs to add

services.prometheus.exporters.rspamd.enable = true;

to the system configuration to have an exporter for rspamd metrics.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This adds a module that configures the json exporter,
which then acts as an exporter for rspamd.
@WilliButz
Copy link
Member Author

@GrahamcOfBorg test prometheus-exporters.rspamd

ping @Ma27

@Ma27 Ma27 merged commit 848ea3a into NixOS:master Sep 11, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 11, 2019

Btw although we're beyond the feature-freeze/branchoff, I'd consider this sufficiently stable to include in 19.09 (actually using that change from the mayflower nixpkgs fork for a while tbh). What do you think @WilliButz?

@WilliButz WilliButz deleted the add-rspamd-exporter branch September 11, 2019 15:05
@WilliButz
Copy link
Member Author

@Ma27 sounds good to me as it's just a module and a test :)

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 11, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 11, 2019

Backported as b41f60f, 25690ef

@Ma27 Ma27 removed the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants