[LayoutNG] Fix vertical-align: top/bottom with leading
#18974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 10, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1795535
branch
from
6e4ed20
to
e21cef5
Compare
This patch fixes non-culled inline boxes to take the `line-height` property into account when computing top or bottom of inline boxes in the line for `vertical-align: top` or `bottom`. Bug: 1001418 Change-Id: Ia53b9894dd81e70e17588bc284f0df4bc4f5c382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795535 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#695443}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1795535
branch
from
e21cef5
to
0e0bcb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes non-culled inline boxes to take the
line-heightproperty into account when computing top orbottom of inline boxes in the line for
vertical-align: toporbottom.Bug: 1001418
Change-Id: Ia53b9894dd81e70e17588bc284f0df4bc4f5c382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795535
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695443}