gnome-multi-writer: init at 3.32.1 #68446
Conversation
| sha256 = "1apdd8yi12zagf82k376a9wmdm27wzwdxpm2wf2pnwkaf786rmdw"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ |
There was a problem hiding this comment.
we need to add hicolor-icon-theme for the setup hook
https://gitlab.gnome.org/GNOME/gnome-multi-writer/blob/master/meson_post_install.sh#L11
Do you think it would make sense to actually move the setup hook to gtk?
There was a problem hiding this comment.
also believe if you add docbook2x we can build the man pages
There was a problem hiding this comment.
IIRC, docbook2x provides a different docbook2man than Debian does, resulting in an error. I will try to add the setup hook later.
There was a problem hiding this comment.
Hmm, I wondered why do we have this in hicolor-icon-theme when it is ussed by GTK only; and actually, Qt implemented support for these files. But still, since gtk-update-icon-cache is part of GTK, should not the clean up script be there as well?
There was a problem hiding this comment.
But still, since gtk-update-icon-cache is part of GTK, should not the clean up script be there as well
I'd agree
Do you think it would make sense to actually move the setup hook to gtk?
You need the tool from gtk to generate it even for qt so it's probably best for it to be there.
There was a problem hiding this comment.
Merging as this will be solved by #68552
Motivation for this change
Another branch that I forgot to PR.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @