Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.wheelUnpackHook: propagate wheel #68452

Merged
merged 1 commit into from Sep 10, 2019
Merged

python.pkgs.wheelUnpackHook: propagate wheel #68452

merged 1 commit into from Sep 10, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Sep 10, 2019

This was accidentally removed when buildPython* was rewritten as hooks.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
python.pkgs.wheelUnpackHook: propagate wheel
c4d5e1b 
This was accidentally removed when buildPython* was rewritten as hooks.
@FRidh FRidh mentioned this pull request Sep 10, 2019
Closed
10 tasks
@FRidh FRidh added this to the 19.09 milestone Sep 10, 2019
@FRidh FRidh added 6.topic: python 0.kind: regression Something that worked before working no longer labels Sep 10, 2019
@FRidh FRidh merged commit c99529a into NixOS:master Sep 10, 2019
@FRidh FRidh deleted the wheel branch September 10, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 6.topic: python
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh