TransferToImageBitmap should reset the bitmap to transparent black #18976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 10, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1796442
branch
from
21dd590
to
ba8b2f2
Compare
It was implemented to reset to black, but it should be transparent black, fixing also the broken tests that were validating the wrong behaviour. Bug: 1001609 Change-Id: I68e51628bd36e19b2c332da60239e6a48ebecf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796442 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#695658}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1796442
branch
from
ba8b2f2
to
47e82d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was implemented to reset to black, but it should be transparent
black, fixing also the broken tests that were validating the wrong
behaviour.
Bug: 1001609
Change-Id: I68e51628bd36e19b2c332da60239e6a48ebecf8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796442
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695658}