Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cue: 0.0.3 -> 0.0.9 #68451

Closed
wants to merge 1 commit into from
Closed

cue: 0.0.3 -> 0.0.9 #68451

wants to merge 1 commit into from

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update
Blocks #68135

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @solson

@rvolosatovs rvolosatovs mentioned this pull request Sep 10, 2019
Merged
10 tasks
@ofborg ofborg bot requested a review from kalbasit September 10, 2019 20:43
@solson
Copy link
Member

solson commented Sep 11, 2019 •
edited

I don't think this will cause a problem, but I'm curious why the switch to fetching from GitHub? The readme states "Our canonical Git repository is located at https://cue.googlesource.com."

@rvolosatovs
Copy link
Member Author

AFAIK fetching from GitHub should be faster and it looked like the project was quite active on GitHub
Should I revert the change?

@solson
Copy link
Member

solson commented Sep 12, 2019

I'm neutral on it, no need to revert.

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@rvolosatovs rvolosatovs deleted the update/cue branch September 12, 2019 15:24
@rvolosatovs rvolosatovs restored the update/cue branch September 12, 2019 15:27
@rvolosatovs rvolosatovs reopened this Sep 12, 2019
@solson
Copy link
Member

solson commented Sep 13, 2019

Should we close in favor of #68668?

@rvolosatovs
Copy link
Member Author

Sure. Short release cycles 😄

@rvolosatovs rvolosatovs deleted the update/cue branch September 13, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvolosatovs @solson @lheckemann