Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scroll-margin WPT to stop flakiness #19027

Merged
merged 1 commit into from Sep 23, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 12, 2019

Updates test 'external/wpt/css/css-scroll-snap/scroll-margin.html' such
that the expected result is consistent. Originally the test's snap
areas were equally distant from the scroll position and therefore the
area chosen was not consistent.

Bug: 964239
Change-Id: I7e8b09719bd526c4e2fb7049131d585ef5e47d8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799387
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Kaan Alsan <alsan@google.com>
Cr-Commit-Position: refs/heads/master@{#698951}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

Updates test 'external/wpt/css/css-scroll-snap/scroll-margin.html' such
that the expected result is consistent. Originally the test's snap
areas were equally distant from the scroll position and therefore the
area chosen was not consistent.

Bug: 964239
Change-Id: I7e8b09719bd526c4e2fb7049131d585ef5e47d8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799387
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Kaan Alsan <alsan@google.com>
Cr-Commit-Position: refs/heads/master@{#698951}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants