New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix many WACK errors #24185
Fix many WACK errors #24185
Conversation
Heads up! This PR modifies the following files:
|
@bors-servo try=windows |
Fix many WACK errors These changes ensure that all native dependencies are built with the compiler flags that will prevent forbidden API uses. They also incorporate a fork of rand_os that backports UWP support from more recent rand releases. This is necessary in the short term to avoid having to wait for the entire ecosystem to migrate to the most recent rand release. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because no windows WACK tests <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24185) <!-- Reviewable:end -->
💔 Test failed - status-taskcluster |
1c738ed
to
afb1be9
Compare
@bors-servo try=windows |
Fix many WACK errors These changes ensure that all native dependencies are built with the compiler flags that will prevent forbidden API uses. They also incorporate a fork of rand_os that backports UWP support from more recent rand releases. This is necessary in the short term to avoid having to wait for the entire ecosystem to migrate to the most recent rand release. Depends on servo/mozjs#200. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because no windows WACK tests <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24185) <!-- Reviewable:end -->
💔 Test failed - status-taskcluster |
This passed the UWP builds and hit and intermittent build error during mozjs in the non-UWP windows build. |
r? @asajeffrey |
afb1be9
to
a81e06d
Compare
a81e06d
to
51353c6
Compare
@asajeffrey This is ready for review. |
Sigh, more patch lines in Cargo.toml. @bors-servo r+ |
📌 Commit 51353c6 has been approved by |
Fix many WACK errors These changes ensure that all native dependencies are built with the compiler flags that will prevent forbidden API uses. They also incorporate a fork of rand_os that backports UWP support from more recent rand releases. This is necessary in the short term to avoid having to wait for the entire ecosystem to migrate to the most recent rand release. Depends on servo/mozjs#200 and servo/rust-mozjs#471. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because no windows WACK tests <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24185) <!-- Reviewable:end -->
☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster |
These changes ensure that all native dependencies are built with the compiler flags that will prevent forbidden API uses. They also incorporate a fork of rand_os that backports UWP support from more recent rand releases. This is necessary in the short term to avoid having to wait for the entire ecosystem to migrate to the most recent rand release.
Depends on servo/mozjs#200 and servo/rust-mozjs#471.
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is