Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix many WACK errors #24185

Merged
merged 2 commits into from Sep 20, 2019
Merged

Fix many WACK errors #24185

merged 2 commits into from Sep 20, 2019

Conversation

jdm
Copy link
Member

@jdm jdm commented Sep 11, 2019

These changes ensure that all native dependencies are built with the compiler flags that will prevent forbidden API uses. They also incorporate a fork of rand_os that backports UWP support from more recent rand releases. This is necessary in the short term to avoid having to wait for the entire ecosystem to migrate to the most recent rand release.

Depends on servo/mozjs#200 and servo/rust-mozjs#471.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because no windows WACK tests

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 11, 2019
@jdm
Copy link
Member Author

jdm commented Sep 11, 2019

@bors-servo try=windows

@bors-servo
Copy link
Contributor

⌛ Trying commit 1c738ed with merge b297454...

bors-servo pushed a commit that referenced this pull request Sep 11, 2019
Fix many WACK errors

These changes ensure that all native dependencies are built with the compiler flags that will prevent forbidden API uses. They also incorporate a fork of rand_os that backports UWP support from more recent rand releases. This is necessary in the short term to avoid having to wait for the entire ecosystem to migrate to the most recent rand release.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because no windows WACK tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24185)
<!-- Reviewable:end -->
@jdm jdm added the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Sep 11, 2019
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Sep 11, 2019
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Sep 11, 2019
@jdm
Copy link
Member Author

jdm commented Sep 11, 2019

@bors-servo try=windows

@bors-servo
Copy link
Contributor

⌛ Trying commit afb1be9 with merge f47cf0b...

bors-servo pushed a commit that referenced this pull request Sep 11, 2019
Fix many WACK errors

These changes ensure that all native dependencies are built with the compiler flags that will prevent forbidden API uses. They also incorporate a fork of rand_os that backports UWP support from more recent rand releases. This is necessary in the short term to avoid having to wait for the entire ecosystem to migrate to the most recent rand release.

Depends on servo/mozjs#200.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because no windows WACK tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24185)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Sep 11, 2019
@jdm
Copy link
Member Author

jdm commented Sep 11, 2019

This passed the UWP builds and hit and intermittent build error during mozjs in the non-UWP windows build.

@jdm
Copy link
Member Author

jdm commented Sep 11, 2019

r? @asajeffrey

@highfive highfive assigned asajeffrey and unassigned avadacatavra Sep 11, 2019
@jdm jdm removed the S-tests-failed The changes caused existing tests to fail. label Sep 11, 2019
@jdm
Copy link
Member Author

jdm commented Sep 16, 2019

@asajeffrey This is ready for review.

@jdm jdm closed this Sep 16, 2019
@jdm jdm reopened this Sep 16, 2019
@jdm jdm removed the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Sep 16, 2019
@asajeffrey
Copy link
Member

Sigh, more patch lines in Cargo.toml. @bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 51353c6 has been approved by asajeffrey

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 20, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 51353c6 with merge b3c2bed...

bors-servo pushed a commit that referenced this pull request Sep 20, 2019
Fix many WACK errors

These changes ensure that all native dependencies are built with the compiler flags that will prevent forbidden API uses. They also incorporate a fork of rand_os that backports UWP support from more recent rand releases. This is necessary in the short term to avoid having to wait for the entire ecosystem to migrate to the most recent rand release.

Depends on servo/mozjs#200 and servo/rust-mozjs#471.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because no windows WACK tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24185)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: asajeffrey
Pushing b3c2bed to master...

@bors-servo bors-servo merged commit 51353c6 into servo:master Sep 20, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants