kdenlive: Avoid exposing configurable paths to melt #68470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kdenlive's configuration stores two paths to the
mlt
package. Thesemay be set in the GUI under
Settings -> Configure Kdenlive -> Environment
, and are persisted in $XDG_CONFIG_HOME/.kdenlivercA problem I encountered was
kdenlive
holding on to oldmlt
pathsin these settings after a nixpkgs update, causing video rendering to fail.
The C++ class kdenlive uses for these settings is automatically
generated, so what this patch does is edit the declaration of the
relevant settings to provide default values with the absolute path of
mlt
known at build time, and mark those settings as hidden.In testing, I've found that changing
mlt
and rebuildingkdenlive
causes updated paths to appear in the GUI, and no entries to be added
to the kdenliverc file.
A shortcoming of this patch is that existing users will already have paths
stored in their
kdenliverc
files that can cause trouble. The hope isthat an approach like the one taken here will reduce this sort
of breakage moving forward.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @