Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-lfs: 2.7.2 -> 2.8.0, ensure go 1.13 compatibility #68455

Merged
merged 1 commit into from Sep 17, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update
Blocks #68135

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Twey

@kalbasit
Copy link
Member

@GrahamcOfBorg build git-lfs

@rvolosatovs rvolosatovs mentioned this pull request Sep 10, 2019
10 tasks
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built and tested locally.

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@rvolosatovs rvolosatovs deleted the update/git-lfs branch September 12, 2019 15:24
@rvolosatovs rvolosatovs restored the update/git-lfs branch September 12, 2019 15:26
@rvolosatovs rvolosatovs reopened this Sep 12, 2019
@ofborg ofborg bot requested a review from kalbasit September 12, 2019 16:14
@rvolosatovs
Copy link
Member Author

@kalbasit can you merge this? It's blocking #68135

@worldofpeace worldofpeace merged commit 2fe6173 into NixOS:master Sep 17, 2019
@rvolosatovs rvolosatovs deleted the update/git-lfs branch September 17, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants