Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shattered-pixel-dungeon: init at 0.7.4c #68487

Merged
merged 1 commit into from Oct 25, 2019
Merged

shattered-pixel-dungeon: init at 0.7.4c #68487

merged 1 commit into from Oct 25, 2019

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Sep 11, 2019

Motivation for this change

https://shatteredpixel.com/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@fgaz fgaz force-pushed the shattered-pixel-dungeon/init branch from 570ecf7 to ed629e4 Compare September 11, 2019 08:34
jonringer
jonringer approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
not sure about diff (not familiar with maven/gradle builds + nix)
executable works

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@fgaz
Copy link
Member Author

fgaz commented Sep 16, 2019

Did ofborg stop automatically building prs?

@GrahamcOfBorg build shattered-pixel-dungeon

Lassulus
Lassulus approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, seems to run correctly, smashed some rats in the first level

@Lassulus Lassulus merged commit 7ff539d into NixOS:master Oct 25, 2019
@fgaz fgaz deleted the shattered-pixel-dungeon/init branch January 20, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fgaz @Lassulus @jonringer @lheckemann