Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

django: don't wrap binary files twice #68486

Merged
merged 1 commit into from Sep 11, 2019
Merged

django: don't wrap binary files twice #68486

merged 1 commit into from Sep 11, 2019

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Sep 11, 2019

Motivation for this change

The bin directory of Django version 1.8, 1.11 and 2.1 contains the django-admin command wrapped twice:

/nix/store/bhyg18ljfyjvjs9gs3yns0nidlj9ni4f-python3.7-Django-1.11.23/bin
├── django-admin
├── django-admin.py
├── .django-admin.py-wrapped
├── ..django-admin.py-wrapped-wrapped
├── .django-admin-wrapped
└── ..django-admin-wrapped-wrapped

This change removes the second wrapper and only keeps the wrapping done by buildPythonPackage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@B4dM4n B4dM4n requested a review from FRidh as a code owner September 11, 2019 07:57
@ofborg ofborg bot requested a review from georgewhewell September 11, 2019 08:11
@Mic92 Mic92 merged commit c7a84aa into NixOS:master Sep 11, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 11, 2019

Backport 713aca0

@B4dM4n B4dM4n deleted the django-doublewrap branch September 11, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@georgewhewell georgewhewell Awaiting requested review from georgewhewell

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @Mic92