Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geolocation] Rename interfaces and remove [NoInterfaceObject] #18989

Merged
merged 1 commit into from Sep 11, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

This change renames the following interfaces and removes the
[NoInterfaceObject] annotation so that these types are now exposed to
script:

Coordinates -> GeolocationCoordinates
Position -> GeolocationPosition
PositionError -> GeolocationPositionError

This is done in response to an effort to remove this annotation from
WebIDL.

Spec pull requests (merged):
w3c/geolocation-api#20
w3c/geolocation-api#23

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Xig9oewsQMA/eyC7dbtiAAAJ

Bug: 931847
Change-Id: I38d0172afc33d5757b664e2807356d8727e82d7f

Reviewed-on: https://chromium-review.googlesource.com/1471230
WPT-Export-Revision: 881a95068879eec4eebf94af037b5dc88da48d18

This change renames the following interfaces and removes the
[NoInterfaceObject] annotation so that these types are now exposed to
script:

  Coordinates   -> GeolocationCoordinates
  Position      -> GeolocationPosition
  PositionError -> GeolocationPositionError

This is done in response to an effort to remove this annotation from
WebIDL.

Spec pull requests (merged):
w3c/geolocation-api#20
w3c/geolocation-api#23

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Xig9oewsQMA/eyC7dbtiAAAJ

Bug: 931847
Change-Id: I38d0172afc33d5757b664e2807356d8727e82d7f
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

assert_equals(position.toString(), "[object Position]",
"Position.toString should result in '[object Position]' was: " + position.toString());
}, "Position toString");
assert_equals(position.toString(), "[object GeolocationPosition]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We so should have called this GeoPosition... too late :)

@marcoscaceres marcoscaceres merged commit 99a9f0b into master Sep 11, 2019
@marcoscaceres marcoscaceres deleted the chromium-export-cl-1471230 branch September 11, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants