New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't find openxr_loader.dll #24181
Comments
I cannot reproduce this in my local environment. I successfully entered immersive mode after installing the OpenXR package from the Windows Store in a debug build in the emulator. |
@jdm can I ask you to clobber first? |
I've been able to run xr content after a full clobber on the device. |
No problem with the device. |
We now use the nuget package too. |
I was wrong. I tested the 2D view only. |
Reverting the nuget commit brings me further (then crash here: servo/webxr#54). There is something that I must be missing. Any idea would help. |
Inspecting the appx package, I see that the openxr_loader.dll is not present. While the dll of the other nuget packages are. My bet is that the nuget package just doesn't include the DLLs. They are present in the nuget package, but they are not included in the final package. I'm just very confused why it works for both of you. Can you |
Yeah, I'm pretty sure this is what's going on: in <Content
Include="$(OpenXRLoaderBinaryRoot)\bin\openxr_loader.dll"
Link="%(Filename)%(Extension)"
CopyToOutputDirectory="PreserveNewest" /> with: <PackagingOutputs Include="$(OpenXRLoaderBinaryRoot)\bin\openxr_loader.dll">
<OutputGroup>OpenXRLoaderBinaries</OutputGroup>
<ProjectName>$(ProjectName)</ProjectName>
<TargetPath>%(Filename)%(Extension)</TargetPath>
</PackagingOutputs> It works. |
Could you raise this with our friends in the Teams channel? |
I can now reproduce this issue in a cleaner build than before. |
I did yesterday. Fixed has been been pushed.
Gonna fix mach clean then. |
Getting this error:
This is the part that fails: https://github.com/Ralith/openxrs/blob/71cea14e8b17eba366c579f28b11d8f135f2a398/openxr/src/entry.rs#L64
Regression started with #24140
For now, only tested on the emulator.
/cc @Manishearth
The text was updated successfully, but these errors were encountered: